Commit 7fc5b0f8 by Vladislav

fix Id in api

1 parent 1887c95f
...@@ -45,7 +45,6 @@ class AdGroupsUpdate extends Command ...@@ -45,7 +45,6 @@ class AdGroupsUpdate extends Command
{ {
$tokens = Tokens::whereHas('dictionaryCampaignsEnabledForExternalUpdated.groupsForExternalForNeedUpdatedForNotReserveUpdate.group') $tokens = Tokens::whereHas('dictionaryCampaignsEnabledForExternalUpdated.groupsForExternalForNeedUpdatedForNotReserveUpdate.group')
->where('type', '!=', Tokens::MAIN) ->where('type', '!=', Tokens::MAIN)
->where('id', 6)
->get(); ->get();
foreach ($tokens as $token) { foreach ($tokens as $token) {
......
...@@ -43,9 +43,20 @@ class UpdateAdGroups extends DirectRequest ...@@ -43,9 +43,20 @@ class UpdateAdGroups extends DirectRequest
foreach ($response['result']['UpdateResults'] as $key => $update_result) { foreach ($response['result']['UpdateResults'] as $key => $update_result) {
if (!isset($update_result['Id'])) { if (!isset($update_result['Id'])) {
Log::debug("UpdateAdGroup, empty Id"); if (isset($update_result['Message']) && $update_result['Message'] === 'Object not found') {
Log::debug($update_result); $goalAdGroup = GoalAdGroup::whereExternalId($this->getParams()['AdGroups'][$key]['Id'])
Log::debug($this->getParams()['AdGroups'][$key]); ->first();
$goalAdGroup->goalKeywords()->delete();
$goalAdGroup->goalAdvertisements()->delete();
$goalAdGroup->goalBidModifiers()->delete();
$goalAdGroup->forceDelete();
} else {
Log::debug("UpdateAdGroup, empty Id");
Log::debug($update_result);
Log::debug($this->getParams()['AdGroups'][$key]);
}
continue; continue;
} }
...@@ -91,7 +102,7 @@ class UpdateAdGroups extends DirectRequest ...@@ -91,7 +102,7 @@ class UpdateAdGroups extends DirectRequest
$list = Variable::getListVariablesByDictionaryCampaign($goalAdGroup->dictionary_campaign_id, $variables); $list = Variable::getListVariablesByDictionaryCampaign($goalAdGroup->dictionary_campaign_id, $variables);
$data = [ $data = [
'Id' => $goalAdGroup->group->external_id, 'Id' => $goalAdGroup->external_id,
'Name' => StrReplaceByVariables::getInstance($goalAdGroup->group->name, $list)->get(), 'Name' => StrReplaceByVariables::getInstance($goalAdGroup->group->name, $list)->get(),
'RegionIds' => $goalAdGroup->group->region_ids, 'RegionIds' => $goalAdGroup->group->region_ids,
]; ];
......
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!