Skip to content

Письменов Дмитрий Иванович / yourroomads

Go to a project
Commit 091da35c by Vladislav
Options

fix add group

1 parent 2ea12603
Inline Side-by-side
Showing with 5 additions and 5 deletions
app/Service/Requests/Direct/AddAdGroups.php
...@@ -142,17 +142,17 @@ class AddAdGroups extends DirectRequest ...@@ -142,17 +142,17 @@ class AddAdGroups extends DirectRequest
$data['SmartAdGroup'] = $goalAdGroup->group->smart_ad_group; $data['SmartAdGroup'] = $goalAdGroup->group->smart_ad_group;
} }
if ($goalAdGroup->negative_keywords && count($goalAdGroup->negative_keywords)) { if ($goalAdGroup->negative_keywords && isset($goalAdGroup->negative_keywords['Items']) && count($goalAdGroup->negative_keywords['Items'])) {
$data['NegativeKeywords'] = [ $data['NegativeKeywords'] = [
'Items' => array_map(function ($value) use ($list) { 'Items' => array_map(function ($value) use ($list) {
return StrReplaceByVariables::getInstance($value, $list)->get(); return StrReplaceByVariables::getInstance($value, $list)->get();
}, $goalAdGroup->negative_keywords), }, $goalAdGroup->negative_keywords['Items']),
]; ];
} }
if ($goalAdGroup->group->negative_keyword_shared_set_ids && count($goalAdGroup->group->negative_keyword_shared_set_ids)) { if ($goalAdGroup->group->negative_keyword_shared_set_ids && isset($goalAdGroup->group->negative_keyword_shared_set_ids['Items']) && count($goalAdGroup->group->negative_keyword_shared_set_ids['Items'])) {
$data['NegativeKeywordSharedSetIds'] = [ $data['NegativeKeywordSharedSetIds'] = [
'Items' => $goalAdGroup->group->negative_keyword_shared_set_ids, 'Items' => $goalAdGroup->group->negative_keyword_shared_set_ids['Items'],
]; ];
} }
......
app/Service/Requests/Direct/GetAdGroups.php
...@@ -103,7 +103,7 @@ class GetAdGroups extends DirectRequest ...@@ -103,7 +103,7 @@ class GetAdGroups extends DirectRequest
'campaign_external_id' => $campaign->external_id, 'campaign_external_id' => $campaign->external_id,
'name' => $ad_group['Name'], 'name' => $ad_group['Name'],
'region_ids' => $ad_group['RegionIds'], 'region_ids' => $ad_group['RegionIds'],
'negative_keywords' => $ad_group['NegativeKeywords'], 'negative_keywords' => $ad_group['c'],
'negative_keyword_shared_set_ids' => $ad_group['NegativeKeywordSharedSetIds'], 'negative_keyword_shared_set_ids' => $ad_group['NegativeKeywordSharedSetIds'],
'tracking_params' => $ad_group['TrackingParams'], 'tracking_params' => $ad_group['TrackingParams'],
'mobile_app_ad_group' => $ad_group['MobileAppAdGroup'] ?? null, 'mobile_app_ad_group' => $ad_group['MobileAppAdGroup'] ?? null,
......
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!