Skip to content

Письменов Дмитрий Иванович / yourroomads

Go to a project
Commit 67a0264f by Vladislav
Options

command log

1 parent 6354433b
Inline Side-by-side
Showing with 24 additions and 25 deletions
app/Service/Requests/Direct/AddAdGroups.php
...@@ -58,15 +58,15 @@ class AddAdGroups extends DirectRequest ...@@ -58,15 +58,15 @@ class AddAdGroups extends DirectRequest
} }
foreach ($response['result']['AddResults'] as $key => $add_result) { foreach ($response['result']['AddResults'] as $key => $add_result) {
$external_id = (string)$add_result['Id'] ?? ''; if (!isset($add_result['Id'])) {
if (!$external_id) {
Log::debug("AddAdGroup, empty Id"); Log::debug("AddAdGroup, empty Id");
Log::debug($add_result); Log::debug($add_result);
Log::debug($this->getParams()); Log::debug($this->getParams());
continue; continue;
} }
$external_id = (string)$add_result['Id'];
$goalAdGroup = $this->goalAdGroups->get($key); $goalAdGroup = $this->goalAdGroups->get($key);
$goalAdGroup->update([ $goalAdGroup->update([
......
app/Service/Requests/Direct/AddCampaigns.php
...@@ -58,15 +58,15 @@ class AddCampaigns extends DirectRequest ...@@ -58,15 +58,15 @@ class AddCampaigns extends DirectRequest
} }
foreach ($response['result']['AddResults'] as $key => $add_result) { foreach ($response['result']['AddResults'] as $key => $add_result) {
$external_id = (string)$add_result['Id'] ?? ''; if (!isset($add_result['Id'])) {
if (!$external_id) {
Log::debug("AddCampaigns, empty Id"); Log::debug("AddCampaigns, empty Id");
Log::debug($add_result); Log::debug($add_result);
Log::debug($this->getParams()); Log::debug($this->getParams());
continue; continue;
} }
$external_id = (string)$add_result['Id'];
$dictionaryCampaign = $this->dictionaryCampaigns->get($key); $dictionaryCampaign = $this->dictionaryCampaigns->get($key);
$dictionaryCampaign->update([ $dictionaryCampaign->update([
......
app/Service/Requests/Direct/GetAdGroups.php
...@@ -53,7 +53,6 @@ class GetAdGroups extends DirectRequest ...@@ -53,7 +53,6 @@ class GetAdGroups extends DirectRequest
function handle($response) function handle($response)
{ {
DB::beginTransaction();
try { try {
$external_ids = []; $external_ids = [];
...@@ -124,7 +123,6 @@ class GetAdGroups extends DirectRequest ...@@ -124,7 +123,6 @@ class GetAdGroups extends DirectRequest
AdGroup::updateOrCreate([ AdGroup::updateOrCreate([
'external_id' => $external_id, 'external_id' => $external_id,
'campaign_external_id' => $campaign->external_id,
], $data); ], $data);
$campaign->update([ $campaign->update([
...@@ -150,9 +148,7 @@ class GetAdGroups extends DirectRequest ...@@ -150,9 +148,7 @@ class GetAdGroups extends DirectRequest
} }
DB::commit();
} catch (\Exception $e) { } catch (\Exception $e) {
DB::rollBack();
Log::debug($e); Log::debug($e);
throw $e; throw $e;
} }
......
app/Service/Requests/Direct/ResumeCampaigns.php
...@@ -34,14 +34,15 @@ class ResumeCampaigns extends DirectRequest ...@@ -34,14 +34,15 @@ class ResumeCampaigns extends DirectRequest
{ {
try { try {
foreach ($response['result']['ResumeResults'] as $resume_result) { foreach ($response['result']['ResumeResults'] as $resume_result) {
$external_id = (string)$resume_result['Id'] ?? ''; if (!isset($resume_result['Id'])) {
Log::debug("ResumeCampaigns, empty Id");
if (!$external_id) {
Log::debug("resumeCampaigns, empty Id");
Log::debug($resume_result); Log::debug($resume_result);
Log::debug($this->getParams());
continue; continue;
} }
$external_id = (string)$resume_result['Id'];
if ($this->getToken()->isMain()) { if ($this->getToken()->isMain()) {
Campaigns::where('external_id', $external_id) Campaigns::where('external_id', $external_id)
->update([ ->update([
......
app/Service/Requests/Direct/SuspendCampaigns.php
...@@ -35,14 +35,15 @@ class SuspendCampaigns extends DirectRequest ...@@ -35,14 +35,15 @@ class SuspendCampaigns extends DirectRequest
{ {
try { try {
foreach ($response['result']['SuspendResults'] as $suspend_result) { foreach ($response['result']['SuspendResults'] as $suspend_result) {
$external_id = (string)$suspend_result['Id'] ?? ''; if (!isset($suspend_result['Id'])) {
if (!$external_id) {
Log::debug("SuspendCampaigns, empty Id"); Log::debug("SuspendCampaigns, empty Id");
Log::debug($suspend_result); Log::debug($suspend_result);
Log::debug($this->getParams());
continue; continue;
} }
$external_id = (string)$suspend_result['Id'];
if ($this->getToken()->isMain()) { if ($this->getToken()->isMain()) {
Campaigns::where('external_id', $external_id) Campaigns::where('external_id', $external_id)
->update([ ->update([
......
app/Service/Requests/Direct/UpdateAdGroups.php
...@@ -48,15 +48,15 @@ class UpdateAdGroups extends DirectRequest ...@@ -48,15 +48,15 @@ class UpdateAdGroups extends DirectRequest
} }
foreach ($response['result']['UpdateResults'] as $key => $update_result) { foreach ($response['result']['UpdateResults'] as $key => $update_result) {
$external_id =(string) $update_result['Id'] ?? ''; if (!isset($update_result['Id'])) {
Log::debug("UpdateAdGroup, empty Id");
if (!$external_id) {
Log::debug("AddAdGroup, empty Id");
Log::debug($update_result); Log::debug($update_result);
Log::debug($this->getParams()); Log::debug($this->getParams());
continue; continue;
} }
$external_id =(string) $update_result['Id'];
GoalAdGroup::forExternal()->needUpdated() GoalAdGroup::forExternal()->needUpdated()
->where('external_id', $external_id) ->where('external_id', $external_id)
->update([ ->update([
......
app/Service/Requests/Direct/UpdateCampaigns.php
...@@ -39,14 +39,15 @@ class UpdateCampaigns extends DirectRequest ...@@ -39,14 +39,15 @@ class UpdateCampaigns extends DirectRequest
{ {
try { try {
foreach ($response['result']['UpdateResults'] as $key => $add_result) { foreach ($response['result']['UpdateResults'] as $key => $add_result) {
$external_id = (string)$add_result['Id'] ?? ''; if (!isset($add_result['Id'])) {
Log::debug("UpdateCampaigns, empty Id");
if (!$external_id) {
Log::debug("AddCampaigns, empty Id");
Log::debug($add_result); Log::debug($add_result);
Log::debug($this->getParams());
continue; continue;
} }
$external_id = (string)$add_result['Id'];
DictionaryCampaign::forExternal()->needUpdated() DictionaryCampaign::forExternal()->needUpdated()
->where('external_id', $external_id) ->where('external_id', $external_id)
->update([ ->update([
......
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!